On Sat, Jan 18, 2020 at 7:56 AM Michael Paquier <michael@paquier.xyz> wrote: > > On Fri, Jan 17, 2020 at 03:07:48PM -0700, legrand legrand wrote: > > Would it be possible to add PGDLLIMPORT to permit to build following > > extensions on windows > > > > pg_stat_sql_plans: > > src/include/pgstat.h > > extern PGDLLIMPORT bool pgstat_track_activities; > > > > pg_background: > > src/include/storage/proc.h > > extern PGDLLIMPORT int StatementTimeout; > > No objections from me to add both to what's imported. >
+1 for adding PGDLLIMPORT to these variables. In the past, we have added it on the request of some extension authors, so I don't see any problem doing this time as well.