Non working timeout detection in logical worker - Mailing list pgsql-hackers

From Julien Rouhaud
Subject Non working timeout detection in logical worker
Date
Msg-id CAOBaU_ZHESFcWva8jLjtZdCLspMj7vqaB2k++rjHLY897ZxbYw@mail.gmail.com
Whole thread Raw
Responses Re: Non working timeout detection in logical worker
List pgsql-hackers
Hello,

Jehan-Guillaume (in Cc) reported me today a problem with logical
replication, where in case of network issue the walsender is correctly
terminating at the given wal_sender_timeout but the logical worker
kept waiting indefinitely.

The issue is apparently a simple thinko, the timestamp of the last
received activity being unconditionally set at the beginning of the
main processing loop, making any reasonable timeout setting
ineffective.  Trivial patch to fix the problem attached.

Attachment

pgsql-hackers by date:

Previous
From: Jeremy Finzel
Date:
Subject: UPSERT on view does not find constraint by name
Next
From: Lars Kanis
Date:
Subject: libpq: Fix wrong connection status on invalid "connect_timeout"