Re: table partition and column default - Mailing list pgsql-hackers

From Julien Rouhaud
Subject Re: table partition and column default
Date
Msg-id CAOBaU_YoYP3NZQNxb_BOo474Ro5umEOa08i_tskrBxMwHZr0eQ@mail.gmail.com
Whole thread Raw
In response to Re: table partition and column default  (Fujii Masao <masao.fujii@gmail.com>)
Responses Re: table partition and column default
List pgsql-hackers
Fuji-san,

On Thu, Dec 26, 2019 at 7:12 AM Fujii Masao <masao.fujii@gmail.com> wrote:
>
> On Wed, Dec 25, 2019 at 5:47 PM Amit Langote <amitlangote09@gmail.com> wrote:
> >
> > On Wed, Dec 25, 2019 at 5:40 PM Fujii Masao <masao.fujii@gmail.com> wrote:
> > > On Wed, Dec 25, 2019 at 1:56 PM Amit Langote <amitlangote09@gmail.com> wrote:
> > > > IIRC, there was some discussion about implementing a feature whereby
> > > > partition's default will used for an attribute if it's null even after
> > > > considering the parent table's default, that is, when no default value
> > > > is defined in the parent.  The details are at toward the end of this
> > > > thread:
> > > >
> > > > https://www.postgresql.org/message-id/flat/578398af46350effe7111895a4856b87b02e000e.camel%402ndquadrant.com
> > >
> > > Thanks for pointing that thread!
> > >
> > > As you mentioned in that thread, I also think that this current
> > > behavior (maybe restriction) should be documented.
> > > What about adding the note like "a partition's default value is
> > > not applied when inserting a tuple through a partitioned table."
> > > into the document?
> >
> > Agreed.
> >
> > > Patch attached.
> >
> > Thanks for creating the patch, looks good to me.
>
> Thanks for reviewing the patch. Committed!

I saw that you only pushed it on master, shouldn't we backpatch it
down to pg10 as this is the declarative partitioning behavior since
the beginning?



pgsql-hackers by date:

Previous
From: Guillaume Lelarge
Date:
Subject: Re: Expose lock group leader pid in pg_stat_activity
Next
From: Julien Rouhaud
Date:
Subject: Re: Expose lock group leader pid in pg_stat_activity