Re: Sparse bit set data structure - Mailing list pgsql-hackers

From Julien Rouhaud
Subject Re: Sparse bit set data structure
Date
Msg-id CAOBaU_Ya9u-TLvm4ZSM6iYKtKRgLmdA1Uz1xJzaoD3j=13FF2Q@mail.gmail.com
Whole thread Raw
In response to Re: Sparse bit set data structure  (Julien Rouhaud <rjuju123@gmail.com>)
List pgsql-hackers
On Thu, Mar 14, 2019 at 4:37 PM Julien Rouhaud <rjuju123@gmail.com> wrote:
>
> +       if (newitem <= sbs->last_item)
> +           elog(ERROR, "cannot insert to sparse bitset out of order");
>
> Is there any reason to disallow inserting duplicates?  AFAICT nothing
> prevents that in the current code.  If that's intended, that probably
> should be documented.

That of course won't work well with SBS_LEAF_BITMAP.  I'd still prefer
a more explicit error message.


pgsql-hackers by date:

Previous
From: "Imai, Yoshikazu"
Date:
Subject: RE: proposal: pg_restore --convert-to-text
Next
From: Kyotaro HORIGUCHI
Date:
Subject: Re: Is PREPARE of ecpglib thread safe?