Re: POC: Extension for adding distributed tracing - pg_tracing - Mailing list pgsql-hackers

From Anthonin Bonnefoy
Subject Re: POC: Extension for adding distributed tracing - pg_tracing
Date
Msg-id CAO6_Xqrs14JYFfKguAjsx4oPXo9-9oLc2edk13sRKMovfDB2bQ@mail.gmail.com
Whole thread Raw
In response to Re: POC: Extension for adding distributed tracing - pg_tracing  (Aleksander Alekseev <aleksander@timescale.com>)
List pgsql-hackers
Hi,

I've rebased and updated the patch with some fixes:
- Removed volatile
- Switched from spinlock to LWLock and removed n_writer
- Moved postgres.h as first header on all files
- Removed possible allocations in PG_CATCH. Though I would probably need to run some more thorough tests on this

I should also have the GitHub repository version of the extension ready this week.

Regards,
Anthonin

On Fri, Mar 15, 2024 at 3:10 PM Aleksander Alekseev <aleksander@timescale.com> wrote:
Hi Anthonin,

> [...]
>
> The usual approach is to have pre-allocated memory. This must actually be written (zeroed usually) or it might be lazily allocated only on page fault. And it can't be copy on write memory allocated once in postmaster startup then inherited by fork.
>
> That imposes an overhead for every single postgres backend. So maybe there's a better solution.

It looks like the patch rotted a bit, see cfbot. Could you please
submit an updated version?

Best regards,
Aleksander Alekseev (wearing co-CFM hat)
Attachment

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: speed up a logical replica setup
Next
From: Daniel Gustafsson
Date:
Subject: Re: Add LSN <-> time conversion functionality