Re: [PATCH] Add additional extended protocol commands to psql: \parse and \bindx - Mailing list pgsql-hackers

From Anthonin Bonnefoy
Subject Re: [PATCH] Add additional extended protocol commands to psql: \parse and \bindx
Date
Msg-id CAO6_Xqr7kUtEv8UrWtYx33tksAwMehHiwaBJxyV9XmL0RVpZiA@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Add additional extended protocol commands to psql: \parse and \bindx  (Michael Paquier <michael@paquier.xyz>)
Responses Re: [PATCH] Add additional extended protocol commands to psql: \parse and \bindx
List pgsql-hackers
> Hmm.  So it does not lead to any user-visible changes, right?

From what I can tell, there's no change in the behaviour. All paths
would eventually go through HandleSlashCmds's cleaning logic. This is
also mentioned in ignore_slash_options's comment.

* Read and discard "normal" slash command options.
*
* This should be used for inactive-branch processing of any slash command
* that eats one or more OT_NORMAL, OT_SQLID, or OT_SQLIDHACK parameters.
* We don't need to worry about exactly how many it would eat, since the
* cleanup logic in HandleSlashCmds would silently discard any extras anyway.

> Could you split the bits for \bind into a separate patch, please?
> This requires a separate evaluation, especially if this had better be
> backpatched.

Done. patch 1 adds ignore_slash_options to bind. patch 2 adds the new
\bindx, \close and \parse commands.

Attachment

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: add function argument names to regex* functions.
Next
From: Kyotaro Horiguchi
Date:
Subject: Re: Network failure may prevent promotion