Re: pgAdmin 4 commit: Fix a number of broken connection detection scenarios - Mailing list pgadmin-hackers
Hi Neel
This issue is not due to the above fix, if you can see the error it is showing in dashboard.js line no 454 "err = JSON.parse(xhr.responseText);" that code is from long time.
I have just added an extra check of the readyState in case of server is down in the above commit.
Though it is a bug can you please create a new RM for this.
On Thu, Apr 5, 2018 at 10:52 AM, Neel Patel <neel.patel@enterprisedb.com> wrote:
Hi Akshay,Due to above commit, when user "Drop" any database it gives exception in browser console.Check attached screenshot.Thanks,Neel PatelOn Wed, Mar 21, 2018 at 2:08 PM, Dave Page <dpage@pgadmin.org> wrote:Fix a number of broken connection detection scenarios.
Branch
------
master
Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif f;h=637f3b9d1a54df8b9a1bfad9e2 6f27fdea407683
Author: Akshay Joshi <akshay.joshi@enterprisedb.com>
Modified Files
--------------
web/pgadmin/dashboard/static/js/dashboard.js | 58 ++++++++++++--------
web/pgadmin/static/js/sqleditor/execute_query.js | 62 +++++++++++----------
.../js/sqleditor/is_new_transaction_required.js | 9 ++++
web/pgadmin/tools/sqleditor/__init__.py | 4 +-
web/pgadmin/tools/sqleditor/static/js/sqleditor.js | 20 ++++---
.../tools/sqleditor/tests/test_start_query_tool.py | 2 +-
.../tools/sqleditor/utils/start_running_query.py | 63 ++++++++++------------
.../utils/tests/test_start_running_query.py | 15 +++++-
.../user_management/static/js/user_management.js | 13 ++++-
.../utils/driver/psycopg2/server_manager.py | 1 +
.../javascript/sqleditor/execute_query_spec.js | 48 ++++++++++++-----
.../sqleditor/is_new_transaction_required_spec.js | 14 ++---
12 files changed, 195 insertions(+), 114 deletions(-)
Akshay Joshi
Sr. Software Architect
Phone: +91 20-3058-9517
Mobile: +91 976-788-8246
Mobile: +91 976-788-8246
pgadmin-hackers by date: