On 13 Jun 2015, at 16:22, Jacek Wielemborek <d33tah@gmail.com> wrote:
Hi,
When an libssh2 call fails, pgAdmin III just shows the error code and nothing else. Consider the following patch - this is what I created while wondering why my hostkeys don't work:
Perhaps we could use this kind of routines wherever rc is being checked?
I have reviewed your patch and it looks good to have error message with error number. I have made some changes in the "LogSSHTunnelErrors" function to avoid duplicate logic for each error message. I have added one default parameter of the session object in the "LogSSHTunnelErrors" function. If we would like to log error message with error number, will have to pass session object. Attached is the modified patch, can you please check it is working or not for your test case.