Don't set the OAUTH2_DISPLAY_NAME, Login button shows 'Login with None' which should be change. Maybe placeholder like <oauth2 display name>.
Fixed
Enter the email address and password. Click on the "Login with ..." button, internal server error displayed on the page, we should throw a proper error message.
Fixed
Code Review:
Empty "__init__.py" file is added in the web folder, I think that is not required.
By mistake, it was added.
Any reason to change messages.pot file manually? It will be updated when we update the message catalog.
I must have run make docs, removed.
Fixed SonarQube issues in the new file 'oauth2.py' and 'test_oauth2_with_mocking.py'. Remove unused imports from both files.
Fixed
Add copyright header to "kerberos.js" file.
Fixed
Documentation:
Remove "of the" from the description of OAUTH2_NAME it is duplicated.
String "Authorisation" should be "Authorization".
Instead of providing "Oauth2 secret", "Oauth2 base url" .... can we provide some more detailed information?
Fixed.
Note: I haven't tested the patch with the proper OAuth2 configuration.