Postgres Pro
Downloads
Home   >   mailing lists

Re: Patch for SonarQube code scan fixes - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: Patch for SonarQube code scan fixes
Date
Msg-id CANxoLDeqU7QCcAbmRetNdAZ5KsfmM=iHx_d5ypMJeXiLpeRa-A@mail.gmail.com
Whole thread Raw
In response to Patch for SonarQube code scan fixes  (Nikhil Mohite <nikhil.mohite@enterprisedb.com>)
List pgadmin-hackers
Tree view
Thanks, patch applied. I have changed the function name from "def _get_reverse_engineered_sql_for_<node name>" to "def _get_resql_for_<node name>", because function name is too long.

On Mon, Jul 13, 2020 at 9:40 AM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:
Hi Team,

I have fixed some code smell issues in the SonarQube scan, PFA patch.
Details as follows:
1. Table file(utils):
  • Refactor this function to reduce its Cognitive Complexity from 39 to the 15 allowed.
  • Refactor this function to reduce its Cognitive Complexity from 122 to the 15 allowed.
  • Refactor this function to reduce its Cognitive Complexity from 58 to the 15 allowed.
2. Table init file:
  • Refactor this function to reduce its Cognitive Complexity from 24 to the 15 allowed.
  • Refactor this function to reduce its Cognitive Complexity from 22 to the 15 allowed.
  • Refactor this function to reduce its Cognitive Complexity from 18 to the 15 allowed.


Regards,
Nikhil Mohite.


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Improve code coverage and API test cases for Foreign
Next
From: Akshay Joshi
Date:
Subject: Re: Re-[pgAdmin][RM-5323]