Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4][RM#4142] Add the recommended ESLinter checks again. - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: [pgAdmin4][RM#4142] Add the recommended ESLinter checks again.
Date
Msg-id CANxoLDeiTX=tTPyj_f62W3OhNVVeiUbvmiHZa-mF58_pVRc0KQ@mail.gmail.com
Whole thread Raw
In response to [pgAdmin4][RM#4142] Add the recommended ESLinter checks again.  (Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>)
List pgadmin-hackers
Tree view
Thanks patch applied.

On Fri, Apr 5, 2019 at 11:49 AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

Issue: We removed recommended ESLinter checking with RM#4019 commit. 

If you see now ESLint is no longer complaining about many issues which are listed here https://eslint.org/docs/rules/ and marked as [✓].
Simple test case is to add debugger; statement in JS code and run linter, we can see that linter is not complaining about it, earlier it was.


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Added recommended ESLinter checks. Fixes #4142
Next
From: Murtuza Zabuawala
Date:
Subject: [pgAdmin4][RM#4138] Allow us to set the dropdown body when renderingSelect2 control