Re: [pgAdmin4][Patch] - SonarQube Issues - 6 (A conditionallyexecuted single line should be denoted by indentation, A "while" loop shouldbe used instead of a "for" loop) - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: [pgAdmin4][Patch] - SonarQube Issues - 6 (A conditionallyexecuted single line should be denoted by indentation, A "while" loop shouldbe used instead of a "for" loop)
Date
Msg-id CANxoLDei-TfxfkFLeLvcJwzNr1=YiQ5NyVnhTJC=DXmzjCYUtA@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4][Patch] - SonarQube Issues - 6 (A conditionallyexecuted single line should be denoted by indentation, A "while" loop shouldbe used instead of a "for" loop)  (Yogesh Mahajan <yogesh.mahajan@enterprisedb.com>)
List pgadmin-hackers
Thanks, patch applied.

On Thu, Jun 25, 2020 at 5:05 PM Yogesh Mahajan <yogesh.mahajan@enterprisedb.com> wrote:
Hi,

Please find patch fixing the issues related to below rules - 
1.A conditionally executed single line should be denoted by indentation, 
2.A "while" loop should be used instead of a "for" loop.

Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


On Thu, Jun 25, 2020 at 12:28 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Yogesh

Please fix the linter error and send the patch again.

On Thu, Jun 25, 2020 at 12:26 PM Yogesh Mahajan <yogesh.mahajan@enterprisedb.com> wrote:
Hi,

Please find patch fixing the issues related to below rules - 
1.A conditionally executed single line should be denoted by indentation, 
2.A "while" loop should be used instead of a "for" loop, \
3.Variables should be declared explicitly)

Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: Re: [pgAdmin4][Patch] - SonarQube Issues - 5 (Rule Boolean checksshould not be inverted, Comma operator should not be used)
Next
From: Akshay Joshi
Date:
Subject: Re: [pgAdmin4][Patch] SonarQube Fixes