Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin][RM3851] Add proper indentation to the code whengenerating a stored procedure - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: [pgAdmin][RM3851] Add proper indentation to the code whengenerating a stored procedure
Date
Msg-id CANxoLDeamkgfaR0KFROdasOMxE6fKZUf7tD19NhFGMnwV6z8hA@mail.gmail.com
Whole thread Raw
In response to [pgAdmin][RM3851] Add proper indentation to the code when generatinga stored procedure  (Rahul Shirsat <rahul.shirsat@enterprisedb.com>)
Responses Re: [pgAdmin][RM3851] Add proper indentation to the code whengenerating a stored procedure  (Rahul Shirsat <rahul.shirsat@enterprisedb.com>)
List pgadmin-hackers
Tree view
Hi Rahul

I have tested your patch and the issue is not fixed. Create one Procedure, Function, and Trigger Function using below code without applying your patch:
BEGIN
      SELECT 1;
END;

Then apply your patch and check the SQL tab. 

On Wed, Jun 24, 2020 at 12:41 AM Rahul Shirsat <rahul.shirsat@enterprisedb.com> wrote:
Hi Hackers,

Please find the attached patch which fixes pg/ppas issues listed below:
  1. Stored procedure code indentation.
  2. Functions code indentation.
  3. Trigger Functions code indentation.
Please review.

--
Rahul Shirsat
Software Engineer | EnterpriseDB Corporation.


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246

pgadmin-hackers by date:

Previous
From: Yogesh Mahajan
Date:
Subject: Re: [pgAdmin4][Patch] - SonarQube Issues - 5 (Rule Boolean checksshould not be inverted, Comma operator should not be used)
Next
From: Yogesh Mahajan
Date:
Subject: [pgAdmin4][Patch] - SonarQube Issues - 6 (A conditionally executedsingle line should be denoted by indentation, A "while" loop should be usedinstead of a "for" loop, Variables should be declared explicitly)