Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working inversion 2.1 - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working inversion 2.1
Date
Msg-id CANxoLDeJv7dwQq9fWxB_i4AxQeEU3fhYn8ZtkXZhrkPrRtnZvQ@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working inversion 2.1  (Joao De Almeida Pereira <jdealmeidapereira@pivotal.io>)
Responses Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working inversion 2.1  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
List pgadmin-hackers
Tree view
Hi Joao

On Tue, 15 May 2018, 19:36 Joao De Almeida Pereira, <jdealmeidapereira@pivotal.io> wrote:
Hi Akshay,

This patch is flaky; it doesn't always pass the tests in our pipeline.

======================================================================

ERROR: runTest (pgadmin.feature_tests.query_tool_tests.QueryToolFeatureTest)

Query tool feature test

----------------------------------------------------------------------

Traceback (most recent call last):

  File "/tmp/build/5988fb0a/pgadmin-repo/web/pgadmin/feature_tests/query_tool_tests.py", line 101, in runTest

    self._query_tool_notify_statements()

  File "/tmp/build/5988fb0a/pgadmin-repo/web/pgadmin/feature_tests/query_tool_tests.py", line 643, in _query_tool_notify_statements

    '//div[contains(@class, "sql-editor-message") and '

  File "/tmp/build/5988fb0a/pgadmin-repo/web/regression/feature_utils/pgadmin_page.py", line 169, in find_by_xpath

    lambda driver: driver.find_element_by_xpath(xpath)

  File "/tmp/build/5988fb0a/pgadmin-repo/web/regression/feature_utils/pgadmin_page.py", line 261, in wait_for_element

    return self._wait_for("element to exist", element_if_it_exists)

  File "/tmp/build/5988fb0a/pgadmin-repo/web/regression/feature_utils/pgadmin_page.py", line 327, in _wait_for

    "Timed out waiting for " + waiting_for_message

  File "/root/.pyenv/versions/pgadmin/lib/python2.7/site-packages/selenium/webdriver/support/wait.py", line 80, in until

    raise TimeoutException(message, screen, stacktrace)

TimeoutException: Message: Timed out waiting for element to exist

All the failures are related to query_tool_notify_statements.  Please take another look.

     There is some serious problems of timeout issues. I have tested it couple of times and working fine. Will test tomorrow one more time. I have followed the code written in the same file. If those test cases have passed then this should also. 

Sincerely,

Victoria & Joao

On Tue, May 15, 2018 at 6:01 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to capture the notification from psycopg2 and displayed it in "Messages" tab of query tool. Added feature test to cover this scenario.

Refer Notification.png file to how it looks in "Messages" tab. Please review it.

--
Akshay Joshi
Sr. Software Architect


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

pgadmin-hackers by date:

Previous
From: Joao De Almeida Pereira
Date:
Subject: Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree
Next
From: Ashesh Vashi
Date:
Subject: Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree