Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4][Patch] - SonarQube Issues - 5 (Rule Boolean checksshould not be inverted, Comma operator should not be used) - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: [pgAdmin4][Patch] - SonarQube Issues - 5 (Rule Boolean checksshould not be inverted, Comma operator should not be used)
Date
Msg-id CANxoLDeGRFyv8gGnVd6F-To+X41VzJ4Jq=oo3zpYf43rYnCUUA@mail.gmail.com
Whole thread Raw
In response to [pgAdmin4][Patch] - SonarQube Issues - 5 (Rule Boolean checks shouldnot be inverted, Comma operator should not be used)  (Yogesh Mahajan <yogesh.mahajan@enterprisedb.com>)
Responses Re: [pgAdmin4][Patch] - SonarQube Issues - 5 (Rule Boolean checksshould not be inverted, Comma operator should not be used)  (Yogesh Mahajan <yogesh.mahajan@enterprisedb.com>)
List pgadmin-hackers
Tree view
Hi Yogesh

After applying your patch a new sonarqube issue has been found "Change this argument to the documented type: Number." in sqleditor_utils.js
Please fix that and resend the patch.

On Mon, Jun 22, 2020 at 4:36 PM Yogesh Mahajan <yogesh.mahajan@enterprisedb.com> wrote:
Hi Hackers,

Please find patch fixing sonarqube issues related to below rules - 

1.Boolean checks should not be inverted, 
2.Comma operator should not be used,
3.Arguments to built-in functions should match documented types,
4.Redundant pairs of parentheses should be removed,

Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246

pgadmin-hackers by date:

Previous
From: Rahul Shirsat
Date:
Subject: [pgAdmin][RM3851] Add proper indentation to the code when generatinga stored procedure
Next
From: Satish V
Date:
Subject: Reg-[pgAdmin4][Patch] - SonarQube - Extra semicolons should beremoved and Method names should comply with a naming convention