Re: [RM#4546] Add RE-SQL tests for Column node - Mailing list pgadmin-hackers

Hello Akshay,

On Fri, Aug 2, 2019 at 11:54 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Hi Murtuza 

Following test cases are missing:

• Primary Key column.

There is no provision to set Primary key from Column dialog, This test case will be covered with Primary key constraint RE-SQL tests.

• Variable options.

Added 

• Precision and Collation.

Added  

• Identity column with 'GENERATED AS BY DEFAULT'.

Added  

• ALTER column with identity values like CYCLE, minimum, maximum etc.. instead of updating comments in such test cases.

Fixed  

• Generated expression should use existing columns if possible like (col1 * col2). 

Fixed 

 

Apart from that can you please look into RM #4500 which seems minor issue. Please send separate patch for both. 

User is looking to provide length and precision for Integer type, which is not possible, We can close this RM.

Please review the attached updated patch.

Regards,

Murtuza

 

On Thu, Aug 1, 2019 at 5:36 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Hi All

I'll review this patch and give my review comments. 

On Wed, Jul 31, 2019 at 4:10 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hi,

PFA patch to add RE-SQL tests for Column node.

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--

Thanks & Regards

Akshay Joshi

Sr. Software Architect

EnterpriseDB Software India Private Limited

Mobile: +91 976-788-8246

--

Thanks & Regards

Akshay Joshi

Sr. Software Architect

EnterpriseDB Software India Private Limited

Mobile: +91 976-788-8246