Postgres Pro
Downloads
Home   >   mailing lists

Re: Patch for SonarQube code scan fixes. - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: Patch for SonarQube code scan fixes.
Date
Msg-id CANxoLDe2pKhWsXAyo2LCn+iiMHqtJQkQY57jeXz3MBRvRvUcAA@mail.gmail.com
Whole thread Raw
In response to Patch for SonarQube code scan fixes.  (Nikhil Mohite <nikhil.mohite@enterprisedb.com>)
List pgadmin-hackers
Tree view
Thanks, patch applied.

On Fri, Jul 31, 2020 at 6:35 PM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:
Hi Team,

I have fixed some code smell issues in the SonarQube scan, PFA patch.
Details as follows:

1. Utils Route:
  • Refactor this function to reduce its Cognitive Complexity from 16 to the 15 allowed.
2. User Management:
  • Refactor this function to reduce its Cognitive Complexity from 16 to the 15 allowed.
  • Refactor this function to reduce its Cognitive Complexity from 18 to the 15 allowed.
3. Query tool preferences:
  • Merge these implicitly concatenated strings; or did you forget a comma?
4. Tool Maintenance:
  • Refactor this function to reduce its Cognitive Complexity from 16 to the 15 allowed.
  • Refactor this function to reduce its Cognitive Complexity from 20 to the 15 allowed.

Regards,
Nikhil Mohite.


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: Re: [pgAdmin][SonarQube] Fixes for 13 rules.
Next
From: Akshay Joshi
Date:
Subject: Re: [pgAdmin 4 - Housekeeping #5327][Code Coverage] Improve API test cases for Schemas and Catalog Objects