Hi Akshay,Please find the updated patch.On Fri, Aug 21, 2020 at 11:53 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi PradipFollowing are the review comments:Change the function name to "_get_supported_browser" instead of "_get_browser_supported".Fixed.Added docstring to the functions in below format:"""<description>:param trans_id::param session_obj::param diff_model_obj::return:"""Fixed.Can we make "_check_cascade_operation" to generic or move that function to PGChildNodeView class and update it in all the nodes where it is used.Fixed. On Thu, Aug 20, 2020 at 8:56 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:Please ignore the previous patch, find the updated patch in this mail.On Thu, Aug 20, 2020 at 8:52 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:Hi Hackers,The attached patch will reduce cognitive complexity for the following functions.web/.../databases/schemas/domains/__init__.py - 16 to 15.web/.../tables/row_security_policies/__init__.py - 17 to 15.web/pgadmin/tools/debugger/__init__.py - 23 to 15user_mapping/__init__.py. 35 to 15.browser/__init__.py.-- Thanks & Regards,Pradip ParkaleSoftware Engineer | EnterpriseDB Corporation-- Thanks & Regards,Pradip ParkaleSoftware Engineer | EnterpriseDB Corporation-- Thanks & RegardsAkshay JoshipgAdmin Hacker | Sr. Software ArchitectEDB PostgresMobile: +91 976-788-8246-- Thanks & Regards,Pradip ParkaleSoftware Engineer | EnterpriseDB Corporation
Hi PradipFollowing are the review comments:Change the function name to "_get_supported_browser" instead of "_get_browser_supported".
Added docstring to the functions in below format:"""<description>:param trans_id::param session_obj::param diff_model_obj::return:"""
"""
<description>
:param trans_id::param session_obj::param diff_model_obj::return:"""
Can we make "_check_cascade_operation" to generic or move that function to PGChildNodeView class and update it in all the nodes where it is used.
On Thu, Aug 20, 2020 at 8:56 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:Please ignore the previous patch, find the updated patch in this mail.On Thu, Aug 20, 2020 at 8:52 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:Hi Hackers,The attached patch will reduce cognitive complexity for the following functions.web/.../databases/schemas/domains/__init__.py - 16 to 15.web/.../tables/row_security_policies/__init__.py - 17 to 15.web/pgadmin/tools/debugger/__init__.py - 23 to 15user_mapping/__init__.py. 35 to 15.browser/__init__.py.-- Thanks & Regards,Pradip ParkaleSoftware Engineer | EnterpriseDB Corporation-- Thanks & Regards,Pradip ParkaleSoftware Engineer | EnterpriseDB Corporation-- Thanks & RegardsAkshay JoshipgAdmin Hacker | Sr. Software ArchitectEDB PostgresMobile: +91 976-788-8246
Please ignore the previous patch, find the updated patch in this mail.On Thu, Aug 20, 2020 at 8:52 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:Hi Hackers,The attached patch will reduce cognitive complexity for the following functions.web/.../databases/schemas/domains/__init__.py - 16 to 15.web/.../tables/row_security_policies/__init__.py - 17 to 15.web/pgadmin/tools/debugger/__init__.py - 23 to 15user_mapping/__init__.py. 35 to 15.browser/__init__.py.-- Thanks & Regards,Pradip ParkaleSoftware Engineer | EnterpriseDB Corporation-- Thanks & Regards,Pradip ParkaleSoftware Engineer | EnterpriseDB Corporation
Hi Hackers,The attached patch will reduce cognitive complexity for the following functions.web/.../databases/schemas/domains/__init__.py - 16 to 15.web/.../tables/row_security_policies/__init__.py - 17 to 15.web/pgadmin/tools/debugger/__init__.py - 23 to 15user_mapping/__init__.py. 35 to 15.browser/__init__.py.-- Thanks & Regards,Pradip ParkaleSoftware Engineer | EnterpriseDB Corporation
pgadmin-hackers by date:
Соглашаюсь с условиями обработки персональных данных