Postgres Pro
Downloads
Home   >   mailing lists

Re: variable scope issue in server js [pgadmin4] - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: variable scope issue in server js [pgadmin4]
Date
Msg-id CANxoLDdo+=8YkAUSRp52kMRcJ-XF0dSQPnL9s57jcODqbvXceg@mail.gmail.com
Whole thread Raw
In response to Re: variable scope issue in server js [pgadmin4]  (Harshal Dhumal <harshal.dhumal@enterprisedb.com>)
List pgadmin-hackers
Tree view


On Thu, May 12, 2016 at 7:47 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi Akshay,

Murtuza hasn't fixed it in all places. He missed in following tow functions
connect_server and disconnect_server

    Thanks - Committed  


-- 
Harshal Dhumal
Software Engineer 




On Thu, May 12, 2016 at 7:38 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi 

On Thu, May 12, 2016 at 5:05 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,


PFA patch for server.js. Replaced ";" (semicolon) with ","  (coma) in variable declaration.

Issue: This was changing scope of all the variables declared after ";" (semicolon) from local to global and therefore affecting all other local variables with same name at different place in same file.

   Thanks- it is already being committed with the patch for "Named Restore Point" send by Murtuza. 




-- 
Harshal Dhumal
Software Engineer 





 --
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers




--
Akshay Joshi
Principal Software Engineer 


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246




--
Akshay Joshi
Principal Software Engineer 


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Fixed variable scope issue in server.js
Next
From: Szabolcs Hubai
Date:
Subject: Re: [PATCH] Fix of elapsed time string generation in query window