[pgAdmin4][Patch]: RM #3607 Edit Data: Not able to remove filter SQL condition - Mailing list pgadmin-hackers

From Akshay Joshi
Subject [pgAdmin4][Patch]: RM #3607 Edit Data: Not able to remove filter SQL condition
Date
Msg-id CANxoLDdnCfiBL8nSDGAOOu1pC5OmZK0gER88Mxp6+oxaR1edtw@mail.gmail.com
Whole thread Raw
Responses Re: [pgAdmin4][Patch]: RM #3607 Edit Data: Not able to remove filterSQL condition  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Hi Hackers,

Attached is the patch to fix the following for filter dialog:
  • OK button should be disabled for Filter dialog when filter string is empty. Filter dialog should be opened using context menu View Data -> Filtered Rows or shortcut toolbar.
  • On validation error dialog should not be closed.
  • User should be able to clear the filter string from the Query Tool.
  • Validation error should be thrown when filter dialog opened from Query Tool and provide some wrong filter string.      
Please review it.

--
Akshay Joshi
Sr. Software Architect


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246
Attachment

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: Re: [pgAdmin4][Patch]: RM #3630 Autocomplete broken in v3.3 release,works in v3.2
Next
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Ensure auto-complete works for objects in schemasoth