Re: [Patch][pgAdmin4]: Fix pgagent issues - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: [Patch][pgAdmin4]: Fix pgagent issues
Date
Msg-id CANxoLDdftZ=w6nfbDsOk8qT-JJr8jBMdRNdWXfJUWtgmWT2Dag@mail.gmail.com
Whole thread Raw
In response to Re: [Patch][pgAdmin4]: Fix pgagent issues  (Neel Patel <neel.patel@enterprisedb.com>)
List pgadmin-hackers
Thanks, patch applied.

On Tue, Apr 21, 2020 at 4:40 PM Neel Patel <neel.patel@enterprisedb.com> wrote:
Hi Akshay,

Please find the attached update patch with the fix. 
Also fixed the Roles resql test cases as it was failing due to timezone change.

Thanks,
Neel Patel

On Tue, Apr 21, 2020 at 12:32 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Neel 

RESQL test cases are failing on my machine due to different timezone 

-     '2020-04-14 01:11:31-07'::timestamp with time zone, '2020-04-15 01:11:34-07'::timestamp with time zone,
?                 -  ^    ^ ^                                         -  ^    ^ ^
+     '2020-04-14 13:41:31+05:30'::timestamp with time zone, '2020-04-15 13:41:34+05:30'::timestamp with time zone,
?                  + ^    ^ ^^^^                                          + ^    ^ ^^^^

Please fix the above issue and resend the patch. 

On Mon, Apr 20, 2020 at 3:07 PM Neel Patel <neel.patel@enterprisedb.com> wrote:
Hi,

Please find the attached patch to stabilize the pgagent and fix below issues.
  • Reverse engineering SQL and MSQL was incorrect when the user added a job schedule with exception Fixes #5356
  • Job schedule exception time was not showing correctly in SQL tab.
  • Identify the job step and schedule if disabled from browser tree, same as pgagent job - Fixes #4636
  • Add RE-SQL/MSQL test cases for pgAgent Jobs - Fixes #4623
Do review it and let me know for comments.

Thanks,
Neel Patel


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Added job step and job schedule disable icons to iden
Next
From: Dave Page
Date:
Subject: Re: [pgAdmin][RM5157] Default sort order at start in view table data by primary key by default