Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox
Date
Msg-id CANxoLDdf8H2CW6Cn+Upbj5k453sfGSWvuKJO+BE_SimVh7wzmA@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox  (Anthony Emengo <aemengo@pivotal.io>)
Responses Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Tree view
Hi Anthony 

Thanks for updated patch, it is working fine on my machine. I have tested it couple of times.

On Sat, May 12, 2018 at 3:48 AM, Anthony Emengo <aemengo@pivotal.io> wrote:

I completely apologize.

With regards to pgadmin.feature_tests.xss_checks_file_manager_test.CheckFileManagerFeatureTest My original fix was working for Firefox but when I tried to adjust it for Chrome, it doesn’t seem to be working reliably for both browsers. What I was able to get working reliably for today was to do a check on what browser was running and run the appropriate wait function (Chrome doesn’t need it). The wait is explicitly for the element to go stale and then un-stale once more.

Screen Shot 2018-05-11 at 5.55.54 PM.png

Screen Shot 2018-05-11 at 5.55.40 PM.png

For what it’s worth however, I have not seen any failures today with pgadmin.feature_tests.pg_datatype_validation_test.PGDataypeFeatureTest, on Firefox.I'm running on an Mac OSX system.

​
Cheers and good weekend! 😀



--
Akshay Joshi
Sr. Software Architect


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246
Attachment

pgadmin-hackers by date:

Previous
From: Ashesh Vashi
Date:
Subject: Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree
Next
From: Aditya Toshniwal
Date:
Subject: [pgAdmin4][RM#3271] Update to the latest 3.x version of jQuery