Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgadmin4][patch] [GreenPlum] Partitioned table icon is the sameas non partitioned tables - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: [pgadmin4][patch] [GreenPlum] Partitioned table icon is the sameas non partitioned tables
Date
Msg-id CANxoLDdaiy7YSHJEwwwwAVnnK7Hq4zo=J9Ugb5Gi1N_qMYRYyQ@mail.gmail.com
Whole thread Raw
In response to [pgadmin4][patch] [GreenPlum] Partitioned table icon is the same asnon partitioned tables  (Joao De Almeida Pereira <jdealmeidapereira@pivotal.io>)
List pgadmin-hackers
Tree view
Thanks Patch applied.

On Wed, Apr 25, 2018 at 2:17 AM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hi Hackers,
Attached you can find 2 patches that correct the Redmine: #3308 A
Patches:
0001 - In this patch we update the SQL to retrieve the is_partitioned flag from the database
0002 - Extract and refactor the icon css class retrieval. It was scattered around the code and we moved it into it's own small class

We also realize that the class was present in some places in the javascript world. What it is strange is that we only override the icon with the partition one after a successful truncation or successful reset of statistics.
Why was this behavior added? Can we remove that?

    Are you referring to "partition.js"? If yes then according to me it's valid because for partitions we only override the icon with the partition one. Please correct me if I am wrong.  


Thanks
Victoria & Joao



--
Akshay Joshi
Sr. Software Architect


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Fixed issue where icon for Partitioned tables wasthe
Next
From: Joao De Almeida Pereira
Date:
Subject: [pgadmin4][patch] Old code failing CI