Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin][Patch] RM 5463 - CSV download quotes numeric columns - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: [pgAdmin][Patch] RM 5463 - CSV download quotes numeric columns
Date
Msg-id CANxoLDdYy5iTSOsOmpHvAvT5qNzu3HX7C6tmeGqhAjKm6TYaeQ@mail.gmail.com
Whole thread Raw
In response to [pgAdmin][Patch] RM 5463 - CSV download quotes numeric columns  (Yogesh Mahajan <yogesh.mahajan@enterprisedb.com>)
Responses Re: [pgAdmin][Patch] RM 5463 - CSV download quotes numeric columns  (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>)
List pgadmin-hackers
Tree view
Hi Aditya

Can you please review it.

On Wed, Jul 8, 2020 at 4:17 PM Yogesh Mahajan <yogesh.mahajan@enterprisedb.com> wrote:
Hi,

Please find a patch which fixes the issue of quoting values of numeric data types like 'bigint, numeric, double precision & real'.

The issue was caused because global type caster are registered for connection in order to avoid javascript compatibility issue for large size data types like real, numeric, double precision, bigint.
Typcaster used to cast these data type values into String, causing quotes to numeric data in downloaded CSV files in case of  "CSV quoting = Strings".

As part of fix, type caster is temporarily unregistered for these numeric data types while creating CSV file & registered back after csv file creation.



Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: Re: [pgAdmin4][RM#5662] [Accessibility] File manager dialog was not rendering properly due to fixed width and height set in the code
Next
From: Akshay Joshi
Date:
Subject: Re: [pgAdmin][RM5569] [SQL] Bad display of tables storage parameters in the "SQL" tab (correction of bug #5398 not complete)