Re: Patch for SonarQube code scan fixes - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: Patch for SonarQube code scan fixes
Date
Msg-id CANxoLDd=9vAoaArcg_+wo6BR_DX8RZmLgA0inphUHvBbKFp9uw@mail.gmail.com
Whole thread Raw
In response to Patch for SonarQube code scan fixes  (Nikhil Mohite <nikhil.mohite@enterprisedb.com>)
List pgadmin-hackers
Thanks, patch applied.

On Thu, Jul 16, 2020 at 9:29 PM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:
Hi Team,

I have fixed some code smell issues in the SonarQube scan, PFA patch.
Details as follows:
1. Servers file(utils):
  • Refactor this function to reduce its Cognitive Complexity from 19 to the 15 allowed.
  • Refactor this function to reduce its Cognitive Complexity from 33 to the 15 allowed.
2. Tablespaces init file:
  • Refactor this function to reduce its Cognitive Complexity from 48 to the 15 allowed.
  • Refactor this function to reduce its Cognitive Complexity from 32 to the 15 allowed.
3. Server Roles init file:
  • Refactor this function to reduce its Cognitive Complexity from 52 to the 15 allowed.
  • Refactor this function to reduce its Cognitive Complexity from 34 to the 15 allowed.
4.  Resource Groups init file:
  • Refactor this function to reduce its Cognitive Complexity from 29 to the 15 allowed.
  • Refactor this function to reduce its Cognitive Complexity from 21 to the 15 allowed.
  • Refactor this function to reduce its Cognitive Complexity from 17 to the 15 allowed.
*In Server roles file one code smell is pending, I will share that in the next patch.

Regards,
Nikhil Mohite


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: Runtime refactoring
Next
From: Dave Page
Date:
Subject: RM 5235 - Support external config files