Re: [pgAdmin4][Patch] - RM 4742 - Can not create Primary key withIndex & 4624 - RE-SQL/MSQL test cases for Primary Keys - Mailing list pgadmin-hackers

Hi Akshay,

Please find the attached updated patch.

On Fri, Sep 13, 2019 at 6:10 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Hi Khushboo 

Following are my review comments: 

• Test cases failed on every server.

Fixed. 

• Delete table scenario is missing in check_constraints and index_constraints.

It is not necessary though I have added. 

• Scenario "Primary Key Constraint with Index" is missing in the 11_plus folder, it is available in the default folder.

Added. 

• Found one issue when we remove fill factor no MSQL is generated and got the error "can't execute an empty query". 

Fixed the existing issue for the Primary key. 

• Index is not visible in the properties dialog when we create primary key using index. 
  

Whenever the Primary key is created using Index, the index name is changed to PK's name.

So, I have hide the Index field from  the Properties and Edit dialogue.

Thanks,

Khushboo 

On Fri, Sep 13, 2019 at 2:41 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:

Hi,

Please find the attached patch to fix below RMs.

1. #4742 - Primary Key Dialog: Can not create Primary key with Index
2. #4624 - Add RE-SQL/MSQL test cases for Primary Keys

Thanks,

Khushboo

--

Thanks & Regards

Akshay Joshi

Sr. Software Architect

EnterpriseDB Software India Private Limited

Mobile: +91 976-788-8246