Re: [pgAdmin][RM7462]: Revisit all the SQL files and remove the SQL for all the unsupported version - Mailing list pgadmin-hackers

Hi Akshay,

Attached is the updated patch.

Thanks & Regards,

Pradip Parkale
Software Engineer | EnterpriseDB Corporation

On Mon, Aug 1, 2022 at 9:57 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Hi Pradip

The following test cases are failing on different database versions:

EPAS 12:

TriggerFuncAddTestCase (Fetch Trigger Function Node URL)
TriggerFuncGetTestCase (Fetch Trigger Function Node URL)
TriggerFuncPutTestCase (Fetch Trigger Function Node URL)
BackupJobTest (When backup the object with the default options)
RestoreJobTest (When restore the object with the default options)
TableGetTestCase (Get: Fetch multiple existing table details,
Get: Fetch non-existing table details)
SchemaSQLTestCase (Error - Get schema SQL using wrong schema id)
ReverseEngineeredSQLTestCases (Reverse Engineered SQL Test Cases)

EPAS 11, 13 and 14:

TriggerFuncAddTestCase (Fetch Trigger Function Node URL)
TriggerFuncGetTestCase (Fetch Trigger Function Node URL)
TriggerFuncPutTestCase (Fetch Trigger Function Node URL)
BackupJobTest (When backup the object with the default options)
RestoreJobTest (When restore the object with the default options)
ReverseEngineeredSQLTestCases (Reverse Engineered SQL Test Cases)

PG 13:

SearchObjectsApiSearch (Search with all types)

PG 14:

ReverseEngineeredSQLTestCases (Reverse Engineered SQL Test Cases)

PG15:

TestRoleDependenciesSql (Test Role Dependencies SQL file)

On Mon, Aug 1, 2022 at 2:58 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:

Hi Akshay,

Please find the updated patch.

Thanks & Regards,

Pradip Parkale
Software Engineer | EnterpriseDB Corporation

On Mon, Aug 1, 2022 at 2:40 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Hi Pradip

Can you please rebase and send the patch?

On Thu, Jul 28, 2022 at 1:34 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:

Hi Hackers,

Please find the updated patch.

This Patch also includes the fix for 7481 [SQL] OWNED BY incorrectly set to NONE when adding user privileges on sequence.

Thanks & Regards,

Pradip Parkale
Software Engineer | EnterpriseDB Corporation

On Wed, Jul 27, 2022 at 9:26 AM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:

Hi Hackers,

Found one minor issue with the implementation.I will send another patch soon.Please don't commit this patch.

My apologies for any inconvenience caused.

Thanks & Regards,

Pradip Parkale
Software Engineer | EnterpriseDB Corporation

On Tue, Jul 19, 2022 at 6:25 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:

Hi Hackers,

Please find the attached patch for #7462. Revisit all the SQL files and remove the SQL for all the unsupported versions.

I have made the following changes:

1. Renamed the 10_plus to default and moved required files to this folder.
2. Removed all the folders below 10.
3. Made similar changes in resql test cases.

Thanks & Regards,

Pradip Parkale
Software Engineer | EnterpriseDB Corporation

--

	Akshay Joshi Principal Software Architect +91 9767888246 www.enterprisedb.com

--

	Akshay Joshi Principal Software Architect +91 9767888246 www.enterprisedb.com