Re: [pgAmin4][Patch] - Kerberos support for Windows Installer - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: [pgAmin4][Patch] - Kerberos support for Windows Installer
Date
Msg-id CANxoLDcimd7gC3oUE4fzFNwyDQESJ1Xw5hmn4iq_9ExWjU3RCg@mail.gmail.com
Whole thread Raw
In response to Re: [pgAmin4][Patch] - Kerberos support for Windows Installer  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
List pgadmin-hackers
Thanks, patch applied.

On Thu, Jan 21, 2021 at 3:46 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi Dave,

Please find the attached updated patch.

Thanks,
Khushbo

On Thu, Jan 21, 2021 at 3:17 PM Dave Page <dpage@pgadmin.org> wrote:
Hi

On Thu, Jan 21, 2021 at 7:11 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached patch to add the Kerberos support in the Windows installer script.

A couple of comments:

- The file names should be in lower case in the COPY lines. It will still work of course, but for consistency and style...
Fixed. 
- There's no check that the environment variable is set to a valid value. For others, we have code block like:

Fixed. 
IF NOT EXIST "%PGADMIN_QT_DIR%" (
ECHO !PGADMIN_QT_DIR! does not exist.
ECHO Please install Qt and set the PGADMIN_QT_DIR environment variable.
EXIT /B 1
)
 
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: http://www.enterprisedb.com



--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Updated Windows installer script for Kerberos support
Next
From: Aditya Toshniwal
Date:
Subject: Re: [pgAdmin][RM1802] ERD Tool (Beta)