Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4][Patch] Feature #3270 Add support for runningregression tests against Firefox - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: [pgAdmin4][Patch] Feature #3270 Add support for runningregression tests against Firefox
Date
Msg-id CANxoLDcgKA6Z1j8D2oT4YgBq5z8FQbrMWzC7a7ek9G740zD5=g@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox  (Anthony Emengo <aemengo@pivotal.io>)
Responses Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Tree view
Thanks Anthony for fixing those two test cases. I have verified it and patch looks good to me. 
Attached is the modified patch where I have remove "import time" which is not required and update the retry message from 10 to 60.

To be honest I have seen some intermittent "Timeout" issues on Chrome and FireFox and those issues are not consistent for any particular test case.

@Hackers, Please review it and if it looks good then commit it. 

On Wed, May 9, 2018 at 3:58 AM, Anthony Emengo <aemengo@pivotal.io> wrote:

Hey, noticed that the patch above seems to fail on our CI pipelines, which run Chrome. Please look at this revised patch that accommodates for both Chrome and Firefox with the wait_for_element_to_reload function.




--
Akshay Joshi
Sr. Software Architect


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246
Attachment

pgadmin-hackers by date:

Previous
From: Anthony Emengo
Date:
Subject: Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox
Next
From: Murtuza Zabuawala
Date:
Subject: [pgAdmin4] To make session cookie more secure (Server mode)