Home > mailing lists

[pgAdmin4][Patch]: Fix for Feature #4334, RM #4496 and #4497 - Mailing list pgadmin-hackers

From	Akshay Joshi
Subject	[pgAdmin4][Patch]: Fix for Feature #4334, RM #4496 and #4497
Date	July 24, 2019 10:09:47
Msg-id	CANxoLDcbVUZUjQiS56g07EHaR3+5340P9QjpES2GC_JoRd5+gg@mail.gmail.com Whole thread Raw
Responses	Re: [pgAdmin4][Patch]: Fix for Feature #4334, RM #4496 and #4497 (Akshay Joshi <akshay.joshi@enterprisedb.com>)
List	pgadmin-hackers

Hi Hackers,

I have added the support of Generated Columns (PG/EPAS 12) and also fixed RM #4496, #4497.

During the implementation of that I have also fixed following issues that I encountered:

User should not be able to provide Default value with Identity column.
'Drop Cascade' button to delete multiple columns should be disabled.
Set "Not Null?" switch to 'Yes' when we create Identity column.
Fix issue when we insert default value for the column and then remove it. It generates wrong msql.
Fix issue when we provide the default value of a column and then select the datatype to serial/bigserial/smallserial, it generates wrong msql.

Modified/Added regression test cases for adding Identity column and Generated columns.

Please review it.

Thanks & Regards

Akshay Joshi

Sr. Software Architect

EnterpriseDB Software India Private Limited

Mobile: +91 976-788-8246

From: Akshay Joshi
Date: 24 July 2019, 08:18:14
Subject: Re: pgAdmin4 v4.11 candidate builds

From: Devrim Gündüz
Date: 24 July 2019, 10:32:43
Subject: Re: pgAdmin4 v4.11 candidate builds