Re: Re-[Sonarqube]- Clumsy code - Mailing list pgadmin-hackers

Hi Akshay,

Please find the updated Patch in the attachment which does not introduce more code smell.

Thanks 

Sathish V

On Thu, Jun 18, 2020 at 12:48 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Hi Satish

Fixes like below will create another code smell in SonarQube:

• !(m.label == 'pg_global') should be (m.label != 'pg_global')
  
• !(_.isUndefined(index) || index == '');
  
• !(_.has(itemData, 'label') && itemData.label === '_RETURN');
  
• .....

Please fix such errors correctly and resend the patch. Make sure functionality should work properly.

On Thu, Jun 18, 2020 at 11:27 AM Satish V <satish.v@enterprisedb.com> wrote:

Hi Hackers,

Please find the patch in the attachment which resolves below issue.

1.Replace this if-then-else statement by a single return statement.

Kindy review and share the changes, if required

Thanks,

Sathish V

--

Thanks & Regards

Akshay Joshi

Sr. Software Architect

EnterpriseDB Software India Private Limited

Mobile: +91 976-788-8246