Re: pgAdmin 1.15 experiences - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: pgAdmin 1.15 experiences
Date
Msg-id CANxoLDc71WMgBSYGB0yNW9j0mKrjNTUdPh6U7uV82xZe8cmtyQ@mail.gmail.com
Whole thread Raw
In response to Re: pgAdmin 1.15 experiences  (Guillaume Lelarge <guillaume@lelarge.info>)
Responses Re: pgAdmin 1.15 experiences  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers


On Fri, Mar 30, 2012 at 1:09 AM, Guillaume Lelarge <guillaume@lelarge.info> wrote:
On Wed, 2012-03-28 at 10:28 +0100, Dave Page wrote:
> That looks OK to me - thanks. Guillaume, what do you think (it's
> fixing a bug in your code :-) ). Basically the problem is in the code
> you added to prevent the same properties dialogue being opened twice,
> or dropping of objects that are open in dialogues. The issue was that
> the code always assumed the selected item in the treeview was the item
> on which it was acting, which is not always the case (for example, you
> might double-click an item in the listview).
>

It seems good to me. I don't reproduce the bug, so I can't say if this
specific patch fixed it. But the patch seems good.

  Dave/Guillaume, If patch looks good to both of you then can anyone please commit it.  



--
Akshay Joshi
Senior Software Engineer 
EnterpriseDB Corporation
The Enterprise PostgreSQL Company
Phone: +91 20-3058-9522
Mobile: +91 976-788-8246

pgadmin-hackers by date:

Previous
From: Guillaume Lelarge
Date:
Subject: Re: Weird code in pgDomain.cpp
Next
From: Dave Page
Date:
Subject: Re: Weird code in pgDomain.cpp