Re: Allow pageinspect's bt_page_stats function to return a set of rows instead of a single row - Mailing list pgsql-hackers

From Hamid Akhtar
Subject Re: Allow pageinspect's bt_page_stats function to return a set of rows instead of a single row
Date
Msg-id CANugjhsD7WK3vMcj_XBF2t2H_u2LhLi6=vg-8eSDV_-sPOEDHw@mail.gmail.com
Whole thread Raw
In response to Re: Allow pageinspect's bt_page_stats function to return a set of rows instead of a single row  ("Drouvot, Bertrand" <bdrouvot@amazon.com>)
List pgsql-hackers


On Fri, 1 Jul 2022 at 13:01, Drouvot, Bertrand <bdrouvot@amazon.com> wrote:

Hi,

On 6/30/22 10:24 AM, Hamid Akhtar wrote:
On Mon, 27 Jun 2022 at 15:52, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> wrote:
On Mon, Jun 27, 2022 at 1:40 PM Drouvot, Bertrand <bdrouvot@amazon.com> wrote:
>
> Hi,
>
> On 6/27/22 9:31 AM, Hamid Akhtar wrote:
>
>
> Hello Hackers,
>
> While working on one of my blogs on the B-Tree indexes, I needed to look at a range of B-Tree page statistics. So the goto solution was to use pageinspect. However, reviewing stats for multiple pages meant issuing multiple queries.

+1 to improve the API.

I think it makes sense too.

But what about the other pageinspect's functions that also use a single blkno as parameter? Should not the patch also takes care of them?

I've started working on that. But it's going to be a much bigger change with a lot of code refactoring.

So, taking this one step at a time, IMHO, this patch is good to be reviewed now.
 

Regards,

Bertrand

pgsql-hackers by date:

Previous
From: Hamid Akhtar
Date:
Subject: Re: explain analyze rows=%.0f
Next
From: Joe Conway
Date:
Subject: Re: Proposal to provide the facility to set binary format output for specific OID's per session