Thanks for the patch, Dipesh.
With a quick look at the patch I have following observations:
----------------------------------------------------------
In bbstreamer_lz4_compressor_new(), I think this alignment is not needed
on client side:
/* Align the output buffer length. */
compressed_bound += compressed_bound + BLCKSZ - (compressed_bound %
BLCKSZ);
----------------------------------------------------------
bbstreamer_lz4_compressor_content(), avail_in and len variables both are
not changed. I think we can simply change the len to avail_in in the
argument list.
----------------------------------------------------------
Comment:
+ * Update the offset and capacity of output buffer based on based on number
+ * of bytes written to output buffer.
I think it is thinko:
+ * Update the offset and capacity of output buffer based on number of
+ * bytes written to output buffer.
----------------------------------------------------------
Indentation:
+ if ((mystreamer->base.bbs_buffer.maxlen - mystreamer->bytes_written) <=
+ footer_bound)
----------------------------------------------------------
I think similar to bbstreamer_lz4_compressor_content() in
bbstreamer_lz4_decompressor_content() we can change len to avail_in.
Regards,
Jeevan Ladhe
Hi,
Hi Robert,
I had an offline discussion with Dipesh, and he will be working on the
lz4 client side decompression part.
Please find the attached patch to support client side compression
and decompression using lz4.
Added a new lz4 bbstreamer to compress the archive chunks at
client if user has specified --compress=clinet-lz4:[LEVEL] option
in pg_basebackup. The new streamer accepts archive chunks
compresses it and forwards it to plain-writer.
Similarly, If a user has specified a server compressed lz4 archive
with plain format (-F p) backup then it requires decompressing
the compressed archive chunks before forwarding it to tar extractor.
Added a new bbstreamer to decompress the compressed archive
and forward it to tar extractor.
Note: This patch can be applied on Jeevan Ladhe's v12 patch
for lz4 compression.
Thanks,
Dipesh
