Re: clang-tidy complaints - Mailing list pgsql-committers

From John Naylor
Subject Re: clang-tidy complaints
Date
Msg-id CANWCAZb0_qSt_e0aq24nCf0O6-+q3byobTY3_wazWwYraHQwQw@mail.gmail.com
Whole thread Raw
In response to clang-tidy complaints  (Peter Geoghegan <pg@bowt.ie>)
List pgsql-committers
On Sat, Apr 12, 2025 at 11:25 PM Peter Geoghegan <pg@bowt.ie> wrote:
>
> I just pushed my annual commit that makes function parameter names
> consistent between function declarations and their corresponding
> definitions, to cover the Postgres 18 cycle.

The new CRC function this touched was right in the header but the
parameter in the definition didn't match match surrounding code (my
fault in 3c6e8c123), so I went ahead and fixed up the definition. (As
an aside, one wrinkle in the clang-tidy result is that it only touched
the declaration in the "runtime check" stanza and not the "targeting
SSE 4.2" stanza.)

--
John Naylor
Amazon Web Services



pgsql-committers by date:

Previous
From: John Naylor
Date:
Subject: pgsql: Match parameter in new function to earlier equivalents
Next
From: David Rowley
Date:
Subject: pgsql: Eliminate divide in new fast-path locking code