Re: Hide exposed impl detail of wchar.c - Mailing list pgsql-hackers

From John Naylor
Subject Re: Hide exposed impl detail of wchar.c
Date
Msg-id CANWCAZacvS0UyhbZ9jGp6MM=59dVyRATujmqCm_EGCjSkGd60w@mail.gmail.com
Whole thread Raw
In response to Re: Hide exposed impl detail of wchar.c  (Nathan Bossart <nathandbossart@gmail.com>)
Responses Re: Hide exposed impl detail of wchar.c
List pgsql-hackers
On Fri, Nov 17, 2023 at 5:54 AM Nathan Bossart <nathandbossart@gmail.com> wrote:
>
> It looks like is_valid_ascii() was originally added to pg_wchar.h so that
> it could easily be used elsewhere [0] [1], but that doesn't seem to have
> happened yet.
>
> Would moving this definition to a separate header file be a viable option?

Seems fine to me. (I believe the original motivation for making it an
inline function was for in pg_mbstrlen_with_len(), but trying that
hasn't been a priority.)



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: trying again to get incremental backup
Next
From: Heikki Linnakangas
Date:
Subject: Re: Relation bulk write facility