On Sat, Apr 5, 2025 at 5:15 AM Nathan Bossart <nathandbossart@gmail.com> wrote:
>
> I noticed that autoconf is defining USE_AVX512_CRC_WITH_RUNTIME_CHECK, but
> everywhere else expects USE_AVX512_CRC32C_WITH_RUNTIME_CHECK (with the
> "32C" included). I tested the v16 patches (with the macro fixed and
> assertions enabled) on a machine with AVX-512 (verified with some extra
> debug logging), and everything passed.
Yikes, I even made a mental note to verify the relevant object file
still had the same contents as v14, and I clearly didn't do that on
the autoconf side. Thanks for running the smoke test! I fixed that,
made a couple more tiny comment changes and pushed.
--
John Naylor
Amazon Web Services