Re: Improve CRC32C performance on SSE4.2 - Mailing list pgsql-hackers

From John Naylor
Subject Re: Improve CRC32C performance on SSE4.2
Date
Msg-id CANWCAZa_iAhjd-6TVY5NfDzyoSJxFgsMrPW0YwKuTMF7a75D9g@mail.gmail.com
Whole thread Raw
In response to Re: Improve CRC32C performance on SSE4.2  (Nathan Bossart <nathandbossart@gmail.com>)
List pgsql-hackers
On Sat, Apr 5, 2025 at 5:15 AM Nathan Bossart <nathandbossart@gmail.com> wrote:
>
> I noticed that autoconf is defining USE_AVX512_CRC_WITH_RUNTIME_CHECK, but
> everywhere else expects USE_AVX512_CRC32C_WITH_RUNTIME_CHECK (with the
> "32C" included).  I tested the v16 patches (with the macro fixed and
> assertions enabled) on a machine with AVX-512 (verified with some extra
> debug logging), and everything passed.

Yikes, I even made a mental note to verify the relevant object file
still had the same contents as v14, and I clearly didn't do that on
the autoconf side. Thanks for running the smoke test! I fixed that,
made a couple more tiny comment changes and pushed.

--
John Naylor
Amazon Web Services



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Back-patch of: avoid multiple hard links to same WAL file after a crash
Next
From: Daniel Gustafsson
Date:
Subject: Re: Removing unneeded self joins