Re: pgsql: Inline CRC computation for small fixed-length input on x86 - Mailing list pgsql-committers

From John Naylor
Subject Re: pgsql: Inline CRC computation for small fixed-length input on x86
Date
Msg-id CANWCAZa7qLYyPAeNvkRJnGgAbsMWZzkzCyd318YoRabqps9TDA@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Inline CRC computation for small fixed-length input on x86  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
On Mon, Mar 31, 2025 at 8:09 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> I wrote:
> > What I conclude is that Red Hat hot-wired gcc to assume -msse4.2,
> > but they didn't hot-wire clang the same way.
>
> In confirmation of that: everything goes through fine if I manually
> add -msse4.2 to configure's choice of BITCODE_CFLAGS.  Not sure if
> that line of thought can lead to a usable solution, or if it's
> superior to messing with the attributes on relevant functions as
> you mooted upthread.

Thanks for doing additional legwork!

Since the broader issue is still up in the air, and we have
confirmation that the attributes will get the buildfarm green again,
I'll go do that now.

--
John Naylor
Amazon Web Services



pgsql-committers by date:

Previous
From: David Rowley
Date:
Subject: pgsql: Fix failing regression test on x86-32 machines
Next
From: John Naylor
Date:
Subject: pgsql: Use function attributes for SSE 4.2 even when targeting that ext