Re: Fix crash when non-creator being an iteration on shared radix tree - Mailing list pgsql-hackers

On Thu, Dec 26, 2024 at 11:59 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> The three patches look good to me.

Thanks for looking! I've pushed them all.

(The failure in drongo seems like an unrelated glitch.)

> > 4. For local memory, an allocated "control object" serves no real
> > purpose and wastes a few cycles on every access. I'm not sure it
> > matters that much as a future micro-optimization, but I mention it
> > here because if we did start allocating outer structs in the callers
> > context, embedding would also remove the need to pfree it.
>
> Using an allocated "control object" can simplify the codes for local
> and shared trees. We cannot embed the control object into
> RT_RADIX_TREE in shared cases. I agree to embed the control data if we
> can implement that cleanly.

I tried this and it was fairly trivial to get working, but it didn't
have the intended effect so I'll leave it alone.

--
John Naylor
Amazon Web Services