Re: [HACKERS] Time based lag tracking for logical replication - Mailing list pgsql-hackers

On 11 May 2017 at 14:12, Petr Jelinek <petr.jelinek@2ndquadrant.com> wrote:

>> Attached patch is Petr's patch, slightly rebased with added pacing
>> delay, similar to that used by HSFeedback.
>>
>
> This looks reasonable. I would perhaps change:
>> +       /*
>> +        * Track lag no more than once per WALSND_LOGICAL_LAG_TRACK_INTERVAL_MS
>> +        */
>
> to something like this for extra clarity:
>> +       /*
>> +        * Track lag no more than once per WALSND_LOGICAL_LAG_TRACK_INTERVAL_MS
>> +        * to avoid flooding the lag tracker on busy servers.
>> +        */

New patch, v3.

Applying in 90 minutes, barring objections.

-- 
Simon Riggs                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers