Re: Unused(?) field Form_pg_sequence.sequence_name, not updated by seq rename - Mailing list pgsql-hackers

From Simon Riggs
Subject Re: Unused(?) field Form_pg_sequence.sequence_name, not updated by seq rename
Date
Msg-id CANP8+jL0YoR3=oUcVWAKyWw+uLNHaVr6xgiqFX7qEbtN74aU2A@mail.gmail.com
Whole thread Raw
In response to Unused(?) field Form_pg_sequence.sequence_name, not updated by seq rename  (Craig Ringer <craig@2ndquadrant.com>)
List pgsql-hackers
On 15 December 2015 at 04:40, Craig Ringer <craig@2ndquadrant.com> wrote:
 
It gets written as part of the Form_pg_sequence each time we write a sequence advance to WAL, but just seems to be a waste of space.

Agreed
 
Am I missing something obvious or should it just be removed? Or perhaps replaced with the sequence's Oid in pg_class, since that'd be quite handy for logical decoding of sequences.

If the name is wrong then probably other fields are wrong also when we do ALTER SEQUENCE? 

We should add the fields you need, but don't alter anything in Form_pg_sequence.

--
Simon Riggs                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: pgbench stats per script & other stuff
Next
From: Andreas Karlsson
Date:
Subject: Check for interrupts in bf and xdes crypt()