Re: Optimizing TransactionIdIsCurrentTransactionId() - Mailing list pgsql-hackers

From Simon Riggs
Subject Re: Optimizing TransactionIdIsCurrentTransactionId()
Date
Msg-id CANP8+jKWO0aphhSEnbVWEJyUpZjYVC4=You+u6pjP-UxW5jcmg@mail.gmail.com
Whole thread Raw
In response to Re: Optimizing TransactionIdIsCurrentTransactionId()  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Optimizing TransactionIdIsCurrentTransactionId()  (Tomas Vondra <tomas.vondra@2ndquadrant.com>)
List pgsql-hackers
On Fri, 20 Dec 2019 at 17:46, Tom Lane <tgl@sss.pgh.pa.us> wrote:
Simon Riggs <simon@2ndquadrant.com> writes:
> On Fri, 20 Dec 2019 at 13:07, Robert Haas <robertmhaas@gmail.com> wrote:
>> With regard to this point, I second Tomas's comments.

> I also agree with Tomas' comments. I am explaining *why* it will be an
> improvement, expanding on my earlier notes.
> This function is called extremely frequently in query processing and is
> fairly efficient. I'm pointing out cases where making it even quicker makes
> sense.

I think the point is that you haven't demonstrated that this particular
patch makes it quicker.

Not yet, but I was trying to agree what an appropriate test would be before running it. 

--
Simon Riggs                http://www.2ndQuadrant.com/
PostgreSQL Solutions for the Enterprise

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Optimizing TransactionIdIsCurrentTransactionId()
Next
From: Stephen Frost
Date:
Subject: Re: Protocol problem with GSSAPI encryption?