Re: pgbench MAX_ARGS - Mailing list pgsql-hackers

From Simon Riggs
Subject Re: pgbench MAX_ARGS
Date
Msg-id CANP8+j+qfcSGdKz4kZc5acf=nRp3PrixycD3LM1qFHDzuLsZ2w@mail.gmail.com
Whole thread Raw
In response to Re: pgbench MAX_ARGS  (Andres Freund <andres@anarazel.de>)
Responses Re: pgbench MAX_ARGS  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Tue, 26 Feb 2019 at 17:38, Andres Freund <andres@anarazel.de> wrote:
Hi,

On 2019-02-26 12:57:14 +0000, Simon Riggs wrote:
> On Tue, 26 Feb 2019 at 12:19, Fabien COELHO <coelho@cri.ensmp.fr> wrote:
> I've put it as 256 args now.
>
> The overhead of that is about 2kB, so not really an issue.

Why not just allocate it dynamically? Seems weird to have all these
MAX_ARGS, MAX_SCRIPTS ... commands.

For me, its a few minutes work to correct a problem and report to the community.

Dynamic allocation, run-time errors is all getting too time consuming for a small thing.
 
The eighties want their constants back ;)

Made me smile, thanks. ;-)

--
Simon Riggs                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: Remove Deprecated Exclusive Backup Mode
Next
From: Tom Lane
Date:
Subject: Re: pgbench MAX_ARGS