Hi,
Thanks for the patch!
On Wed, 23 Aug 2023 at 09:58, Andres Freund <andres@anarazel.de> wrote:
> I'm hoping to push this fairly soon, as I'll be on vacation the last week of
> August. I'll be online intermittently though, if there are issues, I can react
> (very limited connectivity for middday Aug 29th - midday Aug 31th though). I'd
> appreciate a quick review or two.
Patch looks good to me besides some minor points.
v3-0004-ci-Prepare-to-make-compute-resources-for-CI-confi.patch:
diff --git a/.cirrus.star b/.cirrus.star
+ """The main function is executed by cirrus-ci after loading
.cirrus.yml and can
+ extend the CI definition further.
+
+ As documented in .cirrus.yml, the final CI configuration is composed of
+
+ 1) the contents of this file
Instead of '1) the contents of this file' comment, '1) the contents
of .cirrus.yml file' could be better since this comment appears in
.cirrus.star file.
+ if repo_config_url != None:
+ print("loading additional configuration from
\"{}\"".format(repo_config_url))
+ output += config_from(repo_config_url)
+ else:
+ output += "n# REPO_CI_CONFIG_URL was not set\n"
Possible typo at output += "n# REPO_CI_CONFIG_URL was not set\n".
v3-0008-ci-switch-tasks-to-debugoptimized-build.patch:
Just thinking of possible optimizations and thought can't we create
something like 'buildtype: xxx' to override default buildtype using
.cirrus.star? This could be better for PG developers. For sure that
could be the subject of another patch.
Regards,
Nazir Bilal Yavuz
Microsoft
