Re: meson: Optionally disable installation of test modules - Mailing list pgsql-hackers

From Nazir Bilal Yavuz
Subject Re: meson: Optionally disable installation of test modules
Date
Msg-id CAN55FZ2EmdmfBKnP3hqpkaFhEqJ-5B=c6cQ8M-1i86gf5+2vrQ@mail.gmail.com
Whole thread Raw
In response to Re: meson: Optionally disable installation of test modules  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
Responses Re: meson: Optionally disable installation of test modules  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
List pgsql-hackers
Hi,

Thanks for the review.

On Mon, 20 Feb 2023 at 21:44, Peter Eisentraut
<peter.eisentraut@enterprisedb.com> wrote:
>
> I tested this a bit.  It works fine.  The approach makes sense to me.
>
> The install_additional_files script could be simplified a bit.  You
> could use os.makedirs(dest, exist_ok=True) and avoid the error checking.
>    I don't think any callers try to copy a directory source, so the
> shutil.copytree() stuff isn't necessary.  Run pycodestyle over the
> script.  And let's put the script into src/tools/ like the other support
> scripts.
>

I updated the patch in line with your comments.

Regards,
Nazir Bilal Yavuz
Microsoft

Attachment

pgsql-hackers by date:

Previous
From: Nikolay Samokhvalov
Date:
Subject: Re: Proposal: %T Prompt parameter for psql for current time (like Oracle has)
Next
From: Maciek Sakrejda
Date:
Subject: Re: Proposal: %T Prompt parameter for psql for current time (like Oracle has)