Re: tests fail on windows with default git settings - Mailing list pgsql-hackers

From Nazir Bilal Yavuz
Subject Re: tests fail on windows with default git settings
Date
Msg-id CAN55FZ1objLz3Vn5Afu4ojNESMQpxjxKcp2q18yrKF4eKMLENg@mail.gmail.com
Whole thread Raw
In response to Re: tests fail on windows with default git settings  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: tests fail on windows with default git settings
List pgsql-hackers
Hi,

On Wed, 10 Jul 2024 at 17:04, Andrew Dunstan <andrew@dunslane.net> wrote:
>
>
> On 2024-07-10 We 9:25 AM, Tom Lane wrote:
> > Dave Page <dpage@pgadmin.org> writes:
> >> On Wed, 10 Jul 2024 at 12:12, Andrew Dunstan <andrew@dunslane.net> wrote:
> >>> As I was looking at this I wondered if there might be anywhere else that
> >>> needed adjustment. One thing that occurred to me was that that maybe we
> >>> should replace the use of "-w" in pg_regress.c with this rather less
> >>> dangerous flag, so instead of ignoring any white space difference we would
> >>> only ignore line end differences. The use of "-w" apparently dates back to
> >>> 2009.
> >> That seems like a good improvement to me.
> > +1
> >
> >
>
>
> OK, done.

It looks like Postgres CI did not like this change. 'Windows - Server
2019, VS 2019 - Meson & ninja' [1] task started to fail after this
commit, there is one extra space at the end of line in regress test's
output.

[1] https://cirrus-ci.com/task/6753781205958656

-- 
Regards,
Nazir Bilal Yavuz
Microsoft



pgsql-hackers by date:

Previous
From: Tatsuo Ishii
Date:
Subject: CFbot failed on Windows platform
Next
From: Nazir Bilal Yavuz
Date:
Subject: Re: CFbot failed on Windows platform