Re: Add missing error codes to PANIC/FATAL error reports in xlog.c and relcache.c - Mailing list pgsql-hackers

From Nazir Bilal Yavuz
Subject Re: Add missing error codes to PANIC/FATAL error reports in xlog.c and relcache.c
Date
Msg-id CAN55FZ114vZ4_Egm0EfWUZYR_6XYpOXNckyaux4rgTBJDerwpA@mail.gmail.com
Whole thread Raw
In response to Re: Add missing error codes to PANIC/FATAL error reports in xlog.c and relcache.c  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: Add missing error codes to PANIC/FATAL error reports in xlog.c and relcache.c
List pgsql-hackers
Hi,

On Fri, 23 Feb 2024 at 15:34, Daniel Gustafsson <daniel@yesql.se> wrote:
>
> > On 23 Feb 2024, at 13:09, Nazir Bilal Yavuz <byavuz81@gmail.com> wrote:
>
> > Does errmsg_internal() need to be used all the time when turning elogs
> > into ereports? errmsg_internal()'s comment says that "This should be
> > used for "can't happen" cases that are probably not worth spending
> > translation effort on.". Is it enough to check if the error message
> > has a translation, and then decide the use of errmsg_internal() or
> > errmsg()?
>
> If it's an elog then it won't have a translation as none are included in the
> translation set.  If the errmsg is generic enough to be translated anyways via
> another (un)related ereport call then we of course use that, but ideally not
> create new ones.

Thanks for the explanation.

All of your feedback is addressed in v2.

-- 
Regards,
Nazir Bilal Yavuz
Microsoft

Attachment

pgsql-hackers by date:

Previous
From: Andrei Lepikhov
Date:
Subject: Re: "type with xxxx does not exist" when doing ExecMemoize()
Next
From: Bertrand Drouvot
Date:
Subject: Re: Synchronizing slots from primary to standby