Re: Add GoAway protocol message for graceful but fast server shutdown/switchover - Mailing list pgsql-hackers

From Zsolt Parragi
Subject Re: Add GoAway protocol message for graceful but fast server shutdown/switchover
Date
Msg-id CAN4CZFMLpakQb8qohDAnrOoQ1-UrvmzJewZss95Y+Mf_J+iNeA@mail.gmail.com
Whole thread Raw
In response to Re: Add GoAway protocol message for graceful but fast server shutdown/switchover  ("Jelte Fennema-Nio" <postgres@jeltef.nl>)
Responses Re: Add GoAway protocol message for graceful but fast server shutdown/switchover
List pgsql-hackers
+ /*
+ * Only signal regular backends, since those need to notify
+ * their clients using a GoAway message.
+ */
+ if (bp->bkend_type == B_BACKEND)

This condition is slightly different to how SignalChildren works, is
that intentional? I don't think it causes any practical difference,
and I don't see an easy way to reuse SignalChildren for this, but
maybe it could still follow the same pattern.

Otherwise I don't see any other issues, and this also doesn't seem to
be an important comment.

Since the pytest framework seems unlikely to be included in PG19, have
you considered a different test implementation, to have at least some
minimal coverage?



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Passing mac-addresses by value?
Next
From: Yura Sokolov
Date:
Subject: Re: Fix bug in multixact Oldest*MXactId initialization and access