Re: Add GoAway protocol message for graceful but fast server shutdown/switchover - Mailing list pgsql-hackers

From Jelte Fennema-Nio
Subject Re: Add GoAway protocol message for graceful but fast server shutdown/switchover
Date
Msg-id DH1JZEYZOBSW.1QEY6MI45FCIL@jeltef.nl
Whole thread Raw
In response to Re: Add GoAway protocol message for graceful but fast server shutdown/switchover  (Zsolt Parragi <zsolt.parragi@percona.com>)
List pgsql-hackers
On Wed Feb 25, 2026 at 4:08 PM CET, Zsolt Parragi wrote:
> + /*
> + * Only signal regular backends, since those need to notify
> + * their clients using a GoAway message.
> + */
> + if (bp->bkend_type == B_BACKEND)
>
> This condition is slightly different to how SignalChildren works, is
> that intentional? I don't think it causes any practical difference,
> and I don't see an easy way to reuse SignalChildren for this, but
> maybe it could still follow the same pattern.

Changed it to be consistent now, and resolved a rebase conflict.

> Since the pytest framework seems unlikely to be included in PG19, have
> you considered a different test implementation, to have at least some
> minimal coverage?

I now included some basic support for GoAway in psql and added a perl
test based on that.

Attachment

pgsql-hackers by date:

Previous
From: Andrei Lepikhov
Date:
Subject: Re: Vacuum statistics
Next
From: Amit Kapila
Date:
Subject: Re: Skipping schema changes in publication