Re: Fix bug in multixact Oldest*MXactId initialization and access - Mailing list pgsql-hackers

From Yura Sokolov
Subject Re: Fix bug in multixact Oldest*MXactId initialization and access
Date
Msg-id c3eaaac1-d244-4e4d-b5d7-06c284108eac@postgrespro.ru
Whole thread Raw
In response to Re: Fix bug in multixact Oldest*MXactId initialization and access  (Chao Li <li.evan.chao@gmail.com>)
Responses Re: Fix bug in multixact Oldest*MXactId initialization and access
Re: Fix bug in multixact Oldest*MXactId initialization and access
List pgsql-hackers
Good day.

Chao Li and Sami Imseih, thank you for looking at.

After thinking a bit, I've decided to make sizes of arrays precise:
- OldestMemberMXactId's size remains MaxBackends + max_prepared_xacts.
  Instead of changing its size, procno is now adjusted to not include
auxiliary procs.
- OldestVisibleMXactId contains only MaxBackends elemenents now.
  It is used only for real backends and not prepared transactions.

All accesses are validated with asserts certainly.

I believe, index transformation in access of OldestMemberMXactId will not
cost much since all this operations are quite rare.
In the loops arrays are accessed directly since limiting loop index is enough.

-- 
regards
Yura Sokolov aka funny-falcon
Attachment

pgsql-hackers by date:

Previous
From: Zsolt Parragi
Date:
Subject: Re: Add GoAway protocol message for graceful but fast server shutdown/switchover
Next
From: Peter Eisentraut
Date:
Subject: Re: Warning-suppression fixes we ought to back-patch